update SNOMED mapping to include v2 codes #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See details related to the development of this mapping in lassoan/SlicerTotalSegmentator#40 Co-authored-by: David Clunie <dclunie@dclunie.com> Co-authored-by: Andras Lasso <lasso@queensu.ca> Co-authored-by: Rudolph Bumm <rudolf.bumm@googlemail.com> Co-authored-by: Vamsi Krishna Thiriveedhi <vthiriveedhi@mgh.harvard.edu>
|
Thanks for the update. Great work! Yes, the numeric label / ID column can be a bit misleading this way. Probably it is best to remove it. Do you want to update the PR? |
|
Yes, I will update the PR shortly - thank you! |
per discussion, label value will depend on the segmentation task, and keeping it in the mapping file may be misleading
|
@wasserth done! |
|
Great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details related to the development of this mapping in lassoan/SlicerTotalSegmentator#40
@wasserth related to this PR, per discussion with @lassoan in lassoan/SlicerTotalSegmentator#42 (comment), our understanding is that the actual numeric label used in the segmentation result depends on the specific task, and the column in the mapping document that corresponds to the numeric label may be misleading. Maybe it is better to drop that column altogether?