#657 Usuwanie instancji listu z modalem potwierdzającym #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bartosz Gryta <gtktsc@gmail.com>
Co-authored-by: Bartosz Gryta <gtktsc@gmail.com>
Co-authored-by: Bartosz Gryta <gtktsc@gmail.com>
|
Powiązane issue: #657 |
fervero
reviewed
Dec 30, 2020
| { | ||
| title: formatMessage({ id: localeKeys.lists.actions }), | ||
| dataIndex: 'id', | ||
| render: (_, { id, referenceNumber }: Letter) => ( |
There was a problem hiding this comment.
W projekcie jest gdzieś lodash, proponuję jakąś inną nazwę zmiennej zamiast _. Jakąkolwiek. Np. x.
There was a problem hiding this comment.
Underscore jest ignorowany przez prettiera, przez co nie rzuca błędów unused variable.
There was a problem hiding this comment.
Dokładnie tak. To dość powszechna konwencja dla nazwania nie używanych parametrów funkcji, nawet była gdzieś użyta w projekcie ;)
ad-m
approved these changes
Dec 31, 2020
|
@ad-m możesz zmergować? Nie mam uprawnień |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poniżej gif. To samo zachowanie dodaliśmy na usuwanie taga z listy dla spójności.
