General code cleanup #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nst); .editorconfig; package-lock.json; == to === (in obvious cases); and a .jshintrc update.
|
Hey @SamuelMarks! I no longer actively use/maintain waterline and don't plan to invest any time to maintain this module. Worth adding, I've never been much of an active maintainer of this module, so this news should indicate no major loss to the ecosystem. I'm not sure what status is of this module. Wish I could offer more information– best of luck! |
|
@SamuelMarks thanks for helping out. I know that a portion of the Sails community relies on this module, but we aren't investing new effort into it. If you'd like to help out as a maintainer, I'd be happy to discuss further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tjwebb / @devinivy : What is the current plan for this driver?
I noticed sails-postgresql getting updates, and with Waterline 0.13 (1.0) on the horizon, I've migrated to their driver because they support it. Should I bother upgrading—or helping you to—this implementation to be compliant with the next version?