Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and improve documentation for preserve_host #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjb
Copy link
Contributor

@jjb jjb commented Apr 10, 2017

@waterlink i'm pretty sure "omit Host headers" isn't what's going on in either case, right? maybe that's from an earlier version of the library?

@jjb jjb force-pushed the improve-preserve-host-documentation branch from 6650e94 to 359d464 Compare April 10, 2017 19:33
@ktaragorn
Copy link

+1

Infact.. i notice that this behavior seems to be the opposite of apache's behavior is in this regard https://httpd.apache.org/docs/current/mod/mod_proxy.html#proxypreservehost

For that, On means use the same host line as the source_request. Why are they exactly opposite? Apache's makes sense in terms of "preserve" what is being preserved here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants