CAN 2.0B Driver changes #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It have been moved to rocketlib
JasonBrave
requested review from
Joe-Joe-Joe-Joe,
Lucifersan,
ManavToor,
Pdada1,
AshTheEngiqueer and
Rio6
celery6
reviewed
Nov 6, 2024
Comment on lines
+161
to
+165
| rcvd_msg.sid = (uint32_t)RXB1SIDH << 21; | ||
| rcvd_msg.sid |= (((uint32_t)RXB1SIDL >> 5) & 0x7) << 18; | ||
| rcvd_msg.sid |= ((uint32_t)RXB1SIDL & 0x3) << 16; | ||
| rcvd_msg.sid |= (uint32_t)RXB1EIDH << 8; | ||
| rcvd_msg.sid |= RXB1EIDL; |
There was a problem hiding this comment.
add more comments so we know what this is doing at a glance?
There was a problem hiding this comment.
I can put a link to datasheet if you want?
There was a problem hiding this comment.
i was thinking smth like "store the [N:n] bits from rxb1eid into sid" or something like that to describe the bit shifting. unless its really easy to interpret these 5 bitwise ops and im just skill issuing?
There was a problem hiding this comment.
adding datasheet page number is probably good enough
celery6
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CAN driver only, update SID will be done in a separate PR