Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sources/parsley] Update parsley source to generate fake GPS messages for testing #315

Open
EmpiricalCode opened this issue Nov 4, 2024 · 5 comments · May be fixed by #316
Open

[sources/parsley] Update parsley source to generate fake GPS messages for testing #315

EmpiricalCode opened this issue Nov 4, 2024 · 5 comments · May be fixed by #316
Assignees
Labels
enhancement New feature or request

Comments

@EmpiricalCode
Copy link
Contributor

EmpiricalCode commented Nov 4, 2024

Feature Description

  • Expected implementation date: 2024-11-9
  • As a: Developer for omnibus,
  • I would want to: generate fake GPS CAN messages from the parsley source.
  • Because: fake GPS CAN messages are needed for testing new GPS sinks.

Related Links

#265

Details

Note that the original fake messages have been removed as they are outdated. In a future feature request new fake messages should be added to the parsley source.

Note that this feature will only work once a small change to the parsley repo has been made to support the new CAN 2.0 format (I will make a PR for this)


Requirements

Specific Requirements

  • Generated GPS messages MUST comply with CAN Bus 2.0 format.
  • For longitude/latitude, generated coordinates MUST lie within the general Waterloo region.
  • The timestamp MUST wrap around once it exceeds the maximum 3 bytes.

Standard Requirements - Do Not Modify Without Approval

  • All changes made MUST be tested and reviewed by a code reviewer.
  • The conditions outlined in CONTRIBUTING.MD MUST be respected.
  • Deep consider of new library dependencies MUST be made before adding them to the project.
  • Keep the codebase clean, don't push non-code files (e.g. DATA, VirtualEnv, etc.) to the repository.
  • All new feature changes made SHOULD have associated unit tests (if applicable)
  • Keep well-documented code, and follow the style guide.

Satisfying the above requirements WILL close this issue.

Stakeholder / Product Owner

Software Team

@EmpiricalCode EmpiricalCode added the enhancement New feature or request label Nov 4, 2024
@EmpiricalCode EmpiricalCode self-assigned this Nov 4, 2024
@ChrisYx511
Copy link
Contributor

@EmpiricalCode I think the fake GPS data is actually going to be used by software dev people to test GPS functionality and NOT for DAQ people, as DAQ doesn't need fake GPS coordinates since it will get them from real parsley, @zangjiucheng can you confirm?

@ChrisYx511
Copy link
Contributor

but also yay fake GPS data!! 😎 🎉🎉 🎉 🎉

@zangjiucheng
Copy link
Member

Yep, you are right :)) This is for software team easier for UI development but don't need to download large dataset. DAQ system they don't need to care with this.

@zangjiucheng
Copy link
Member

It not a big deal, not mandatory require to change the issue description, but just clarify.

@EmpiricalCode
Copy link
Contributor Author

Got it, will leave as "Software Team"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants