Add fake GPS messages to parsley source, remove old messages #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the old fake messages under
FakeSerialCommunicator
as well as the code populating those fake messages, as the messages are outdated.Updated
FakeSerialCommunicator.__init__
andFakeSerialCommunicator.read
to generate new fake messages (currently only related to GPS). These messages are based on an omnibus log saved from a previous competition and the RocketCAN packet docs.Note: parsley repo must be updated to support new format of messages. Will create a PR for this.
This PR closes #315.
Developer Testing
Here's what I did to test my changes:
parsley
source with the--fake
flag through omnibus bus into theprinter
sink to make sure the messages were being encoded properly.Reviewer Testing
Here's what you should do to quickly validate my changes:
This change is