Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake GPS messages to parsley source, remove old messages #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EmpiricalCode
Copy link
Contributor

@EmpiricalCode EmpiricalCode commented Nov 4, 2024

Description

Removed the old fake messages under FakeSerialCommunicator as well as the code populating those fake messages, as the messages are outdated.

Updated FakeSerialCommunicator.__init__ and FakeSerialCommunicator.read to generate new fake messages (currently only related to GPS). These messages are based on an omnibus log saved from a previous competition and the RocketCAN packet docs.

Note: parsley repo must be updated to support new format of messages. Will create a PR for this.

This PR closes #315.

Developer Testing

Here's what I did to test my changes:

  • Ran the parsley source with the --fake flag through omnibus bus into the printer sink to make sure the messages were being encoded properly.
  • Artificially set the timestamp to 16,777,000 and made sure the it was reset back to 0 once it exceeded 16,777,215.
  • Manually took DDM coordinates of generated messages and made sure they were within the Waterloo region.

Reviewer Testing

Here's what you should do to quickly validate my changes:

  • Take some generated coordinates and check they are in the Waterloo region.
  • Make sure generated values are accurate to what is expected from real-world data (num_sats, quality, etc).

This change is Reviewable

@EmpiricalCode EmpiricalCode requested review from a team as code owners November 4, 2024 23:54
@zangjiucheng
Copy link
Member

I am going to review the PR tmr, tested run a few issue need to be solved. But excellent work!

Copy link
Member

@zangjiucheng zangjiucheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :)) Just wait for parsley PR and test again before merge.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sources/parsley] Update parsley source to generate fake GPS messages for testing
2 participants