PIC18 I2C Driver #14
Open
PIC18 I2C Driver #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pic18f26k83/i2c.c
Outdated
| @@ -115,7 +115,18 @@ bool i2c_write_reg16(uint8_t address, uint8_t reg, uint16_t val) { | |||
| } | |||
|
|
|||
| bool i2c_read_reg8(uint8_t address, uint8_t reg, uint8_t *value) { | |||
| return i2c_read_data(address, reg, value, 1); | |||
| bool success = i2c_write(address, ®, 1); | |||
There was a problem hiding this comment.
Add some comments with a link to the data sheet of a relevent IC explaining what this protocol is and why its needed
JasonBrave
force-pushed
the
i2c-compile-fix
branch
from
7eebde5 to
9fe4601
Compare
JasonBrave
force-pushed
the
i2c-compile-fix
branch
from
9fe4601 to
41cc05c
Compare
taisirhassan
force-pushed
the
i2c-compile-fix
branch
from
41cc05c to
da5840b
Compare
…ng and type safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.