Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/refactor to files #2

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Task/refactor to files #2

merged 4 commits into from
Feb 22, 2022

Conversation

estebandalel-p44
Copy link
Contributor

Refactored the huge file to easier to read folders

Copy link
Contributor

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor works and you can merge. Abstracting code the way you did it is an elegant way of organizing stuff.

But I have some high-level questions answered please (they should be probably addressed in some other PR):

  1. Can we remove those annoying toasts? They accumulate pretty fast and are an obstacle for clicking things on the actual VS Code UI.

  2. Should we remove console logs for safety?

  3. Is the test/suite dir necessary for our MVP and near-future product iterations?

@estebandalel-p44
Copy link
Contributor Author

Will merge.

1. Can we remove those annoying toasts? They accumulate pretty fast and are an obstacle for clicking things on the actual VS Code UI.

Yes, they are for debug. They run natively and don't require opening devtools.

2. Should we remove console logs for safety?

Yeah, maybe have a debug logger.

3. Is the test/suite dir necessary for our MVP and near-future product iterations?

I'd like to add CI in the short term, at least a test to see that it opens (smoke test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants