Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Add the ruby case, and add the [input=email] string as a counter example #367

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

baristaGeek
Copy link
Collaborator

Description

This PR does 2 things:

  1. Adds Ruby example for console log detection
  2. Adds a false positive we recently got reported as a counter-example to make the detection more strict

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Acceptance

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 1:34am

WatermelonAI Summary

This PR adds a Ruby example for console log detection and also includes a false positive as a counter-example to make the detection more strict. It is a bug fix and a new feature that improves the detection of console logs.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
No results found in Notion Pages :(

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

@baristaGeek
Copy link
Collaborator Author

ON #368 it detected the puts and not the 'input[type="email"]'

Screen Shot 2023-11-10 at 11 45 57 AM

WatermelonAI Summary

This PR adds a Ruby example for console log detection and includes a false positive as a counter-example. It also pins Next to v13. The goal is to improve the detection and make it more strict.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
No results found in Notion Pages :(

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on any JetBrains IDE!

WatermelonAI Summary

This PR adds a Ruby example for console log detection and adds a false positive as a counter example to make the detection stricter. It also includes a commit to pin Next to v13 and another commit to merge the dev branch into feature/ruby-case.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
No results found in Notion Pages :(

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants