-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoobot/patch/crosswalk fixes #17
Conversation
What are you thinking for the following fields: |
Country names can be quite long and not everyone agrees or spells them the same. Hoping to move to one of these for country lookup. It hasn't trickled into the FE or server code base yet though. iso_alpha_2 or iso_alpha_3? I think id_city_name is just lowercased city. We probably don't need both especially since we are moving id to id_name. |
Thanks for the info on those fields. That makes sense. Do we want to make them camelCase as well? |
Yeah probably to be consistent. |
I'll add another commit to make them camelCase. Will put this back in draft until that's done. |
…d id for source, added idName for source id
@tzinckgraf This is ready to go |
I think it'll work better if this one goes in before #18 |
LGTM. Thanks for making those changes. |
Changed fields to camelCase to match rest of code.
Needs #18