User Profile Redesign - refactor to eliminate styled components #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoobot
reviewed
Sep 14, 2023
| align-items: center; | ||
| margin-bottom: 2em; | ||
|
|
||
| .user-avatar { |
There was a problem hiding this comment.
Here's an example of how we are nesting css so you can just have a root class
https://github.com/waterthetrees/wtt_front/blob/main/client/src/components/SourceForm/SourceForm.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
#635
REASON:
Currently, the
UserInfoContainercomponent is using styled components, which we want to phase out.I've removed the styled components
UserInfoContainerBoxandUserAvatar, and replaced them with custom classes in a new CSS fileUserInfoContainer.scss.This is refactoring under the hood and should not affect the UX/UI in the browser in any way.