net: throw error to given objectMode in connection

Fixes: nodejs#40336
watilde · Oct 6, 2021 · 80e3dec · 80e3dec
1 parent 87da53c
commit 80e3dec
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -194,6 +194,9 @@ function connect(...args) {
   const normalized = normalizeArgs(args);
   const options = normalized[0];
   debug('createConnection', normalized);
+  if (options.objectMode) {
+    throw new ERR_INVALID_ARG_VALUE('options.objectMode', options.objectMode, 'is not supported');
+  }
   const socket = new Socket(options);
 
   if (options.timeout) {

diff --git a/test/parallel/test-net-connect-options-invalid.js b/test/parallel/test-net-connect-options-invalid.js
@@ -0,0 +1,20 @@
+'use strict';
+const assert = require('assert');
+const net = require('net');
+
+{
+  const ArgValueInvalidError = {
+    code: 'ERR_INVALID_ARG_VALUE',
+    name: 'TypeError'
+  };
+
+  const option = {objectMode: true};
+
+  assert.throws(() => {
+    net.createConnection(option);
+  }, {
+    code: 'ERR_INVALID_ARG_VALUE',
+    name: 'TypeError',
+    message: /The property 'options.objectMode' is not supported. Received true/
+  });
+}