Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved presentation + website #349

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Atlinx
Copy link
Contributor

@Atlinx Atlinx commented Aug 13, 2022

I really like this plugin, and I thought I could improve its presentation to attract more people. I've added a banner and an Angular website that should be hosted on github pages. All of this is based on @Jummit's logo and color scheme.

You can check out the revamped repo here, and the website here.

@AlexDarigan
Copy link
Collaborator

AlexDarigan commented Aug 13, 2022

Damn! I completely appreciate the work done here but I'm going to be honest with you, I don't think WAT is currently in a state for a proper website. I currently have a private repo where I'm trying to handle WAT in a slightly more micro-servicey way through the use of servers (probably using JSONRPC)

The intention there is threefold;

Firstly we can handle all of the language specific things in the Clients (so instead of running into weird issues like no .new() found on uncompiled csharp scripts, we just instead collect the C# files through a C# client) & secondly, the existence of a server will allow plugins (like Rider, Code etc) to hook into the testing by acting as a Test Client*.

*It is technically possible for VSCode to do this already through the use of godot-tools & the LSP but that's gdscript only (I believe). The system I'm proposing could add support for new languages by simply creating an external test client (responsible for discovering tests & displaying results) along with a package of a test-driver, test-class & set of assertions added to the main plugin.

Feel free to message me or catch me on Discord for more.

@Atlinx
Copy link
Contributor Author

Atlinx commented Aug 14, 2022

Thanks for catching me up to the state of the plugin! I think your microservice approach is really neat and could make it a whole lot easier to add new language and client support. I'm not too familiar with local servers and JSONRPC, but I'd be happy to help out with development. Is this going to be the framework that WAT will use with Godot 4.0 and onward?

@AlexDarigan
Copy link
Collaborator

JSONRPC more or less just means sending a JSON Object and interpreting it as a method call and returning the result.

This probably will be the framework going onward for the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants