-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[speech-to-text] handle Edge case: zero result entries. #198
Comments
Thanks, good catch. I fixed it and added a test. Question for you (and @germanattanasio and @jsstylos): What do you expect the stream to output for a silent audio file: no (I just copied in your fix which results in no UPDATE: I talked to some folks on the #Node.js IRC and they seem to agree that the current solution (no |
Oh, and sorry @monte-hayward - I started looking at this after your first commit and didn't realize that you were also working on a test. It looks like yours is going to be more comprehensive than mine, so we'll go ahead and merge it in once you're ready. One of us will just have to deal with the conflicts. |
@monte-hayward thanks for your contribution! |
Can occur when a pipeline sends a chunk of audio that is silent.
The text was updated successfully, but these errors were encountered: