Sdk minor release 2024 #1203
Merged
Sdk minor release 2024 #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New param list: smartFormattingVersion, force, mappingOnly
apaparazzi0329
force-pushed
the
sdk-minor-release-2024
branch
from
74cc66f to
ff6d067
Compare
jeff-arn
reviewed
Feb 26, 2024
Comment on lines
-199
to
+193
| const sdkHeaders = getSdkHeaders( | ||
| AssistantV2.DEFAULT_SERVICE_NAME, | ||
| 'v2', | ||
| 'listAssistants' | ||
| ); | ||
| const sdkHeaders = getSdkHeaders(AssistantV2.DEFAULT_SERVICE_NAME, 'v2', 'listAssistants'); |
There was a problem hiding this comment.
are these indent changes a deliberate stylistic change or are we forgetting to run something like prettier?
There was a problem hiding this comment.
They are a deliberate stylistic change from the sdk-generator
BREAKING CHANGE: Renaming and changing of multiple interfaces
apaparazzi0329
force-pushed
the
sdk-minor-release-2024
branch
from
b3e1a38 to
3b9e410
Compare
jeff-arn
approved these changes
Feb 26, 2024
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.