Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nock@3.4.0 untested ⚠️ #172

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello 👋

⚠️⚠️⚠️

nock just published its new version 3.4.0, which is covered by your current version range. No automated tests are configured for this project.

This means it’s now unclear whether your software still works. Manually check if that’s still the case
and close this pull request – if it broke, use this branch to work on adaptions and fixes.

Do you think getting a pull request for every single new version of your dependencies is too noisy? Configure continuous integration and you will only receive them when tests fail. 

Happy fixing and merging 🌴


This pull request was created by greenkeeper.io.
It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡

germanattanasio added a commit that referenced this pull request Dec 7, 2015
@germanattanasio germanattanasio merged commit f7407dc into master Dec 7, 2015
@germanattanasio germanattanasio self-assigned this Dec 7, 2015
@germanattanasio
Copy link
Contributor

looks like everything is working locally, I don't know why the tests were failing

@germanattanasio germanattanasio deleted the greenkeeper-nock-3.4.0 branch December 7, 2015 16:26
@nfriedly
Copy link
Contributor

nfriedly commented Dec 7, 2015

@germanattanasio

> watson-developer-cloud@1.0.5 test /home/travis/build/watson-developer-cloud/node-sdk

> jshint --exclude ./node_modules/ && mocha --reporter spec --timeout 4000

/home/travis/build/watson-developer-cloud/node-sdk/lib/index.js:51

      throw new Error('Argument error: version was not specified');

I fixed something similar to this where the integration test was expecting auth.visual_recognintion.v1 and .v2, to be objects with credentials, but instead the encrypted auth.js just had a single set of credentials for v2 stored at auth.visual_recognition - and because it tried to create the service in the describe() block instead of in the it() block, it failed before the tests even started.

@nfriedly
Copy link
Contributor

nfriedly commented Dec 7, 2015

In general, this encrypted credentials business is turning out to be a bit of a PITA. Maybe we should look at storing them in env properties for travis and a .env file for local testing (?)

(Travis lets you add arbitrary private env in two places: at https://travis-ci.org/watson-developer-cloud/node-sdk/settings and storing them encrypted in .travis.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants