[tradeoff-analytics] Add support for "generate_visualization"

[dolevdotan]

Added support to the generate_visualization query param

[germanattanasio]

Can we change

qs: params.generate_visualization === false ? {'generate_visualization': false} : undefined,

to be:

qs: pick(params, ['generate_visualization'] ),

[dolevdotan]

the reason I did it like that is that I wanted to go with a more 'strict'
approach, and accept only booleans. Maybe I should have added some
assertion to check this.

2015-12-24 18:36 GMT+02:00 German Attanasio Ruiz notifications@github.com:

In services/tradeoff_analytics/v1.js
#191 (comment)
:

   headers: {
     'x-watson-metadata' : params.metadata_header
   },

•  qs: params.generate_visualization === false ? {'generate_visualization': false} : undefined,
  

Can we change

qs: params.generate_visualization === false ? {'generate_visualization': false} : undefined,

to be:

qs: pick(params, ['generate_visualization'] ),

—
Reply to this email directly or view it on GitHub
https://github.com/watson-developer-cloud/node-sdk/pull/191/files#r48420472
.

[germanattanasio]

@dolevdotan can you update your dev branch(dolevdotan:dev) so that this PR reflects only your changes?

[dolevdotan]

I have no idea how to do this... I did as you requested, forked and worked
in 'dev' branch. That's all I know how to do.
If you can give me simple instructions (git commands), I guess I could do
it...

2015-12-24 18:42 GMT+02:00 German Attanasio Ruiz notifications@github.com:

@dolevdotan https://github.com/dolevdotan can you update your dev
branch(dolevdotan:dev) so that this PR reflects only your changes?

—
Reply to this email directly or view it on GitHub
#191 (comment)
.

[germanattanasio]

You can do it using the github ui. Creating a pull request from wdc dev to
your fork dev

On Thu, Dec 24, 2015, 4:53 PM Dolev Dotan notifications@github.com wrote:

I have no idea how to do this... I did as you requested, forked and worked
in 'dev' branch. That's all I know how to do.
If you can give me simple instructions (git commands), I guess I could do
it...

2015-12-24 18:42 GMT+02:00 German Attanasio Ruiz <notifications@github.com

:

@dolevdotan https://github.com/dolevdotan can you update your dev
branch(dolevdotan:dev) so that this PR reflects only your changes?

—
Reply to this email directly or view it on GitHub
<
#191 (comment)

.

—
Reply to this email directly or view it on GitHub
#191 (comment)
.

[dolevdotan]

ok, done.