Support geometry columns via brick/geo #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcinai
force-pushed
the
feature/database-geometry-type
branch
from
5025d75 to
c41fe96
Compare
|
Maybe we add automatic handling in |
|
Or just geoJSON 🤯 |
Can't use `bindParam` here because its by reference, and in the context of the loop every bound parameter has the value of whatever the last parameter in the loop was. `bindValue` is not by reference, and still allows the type to be set separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic geometry support to the database via
brick/geoThe main change (aside from storing the type on the field) is to allow arrays to be passed to the prepare methods, which can get unpacked into the optional params.
note. The $name+1 is due to the parameters expected to be 1-indexed.