Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add predicate to only trigger on spec or annotation changes #168

Merged
merged 1 commit into from
May 13, 2024

Conversation

jabdoa2
Copy link
Contributor

@jabdoa2 jabdoa2 commented May 8, 2024

On our clusters (1k Deployments, 5k Secrets) wave does not use significant CPU (about 10m) or memory (250MB). However, it causes API requests (not excessive but still more than 0) and we try to minimize that to keep kube-apiserver and etcd responsive.

The best way to improve performance it so do less. Previously, wave would trigger on changes in the status resource of Deployments, StatefulSets and DaemonSets. Those changes obviously are not interesting at all for wave and only cause noop reconciles.

This change will change the watch to only trigger a reconcile when annotations change or the spec changes.

@jabdoa2 jabdoa2 requested a review from a team as a code owner May 8, 2024 15:38
@toelke toelke merged commit 9463f15 into wave-k8s:master May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants