add predicate to only trigger on spec or annotation changes #168
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our clusters (1k Deployments, 5k Secrets) wave does not use significant CPU (about 10m) or memory (250MB). However, it causes API requests (not excessive but still more than 0) and we try to minimize that to keep kube-apiserver and etcd responsive.
The best way to improve performance it so do less. Previously, wave would trigger on changes in the status resource of Deployments, StatefulSets and DaemonSets. Those changes obviously are not interesting at all for wave and only cause noop reconciles.
This change will change the watch to only trigger a reconcile when annotations change or the spec changes.