Update kubebuilder #177
Merged
Update kubebuilder #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toelke
approved these changes
Oct 17, 2024
|
Thank you for the contribution! |
|
Can you tag a release in the next few days? We learned the hard way that using a 1.29 client on kubernetes 1.30 can still cause issues. By definition the api client is compatible for +/- one kubernetes version. However, we did not know that this does not apply to any alpha APIs. In this case the mutating webhook will simply remove those newer APIs in pods which can cause adverse side-effects in some charts. |
|
Done, chart version 4.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we currently cannot upgrade further to controller-runtime 0.19 due to issues with kubernetes 1.31 api and ginko v2. See kubernetes/code-generator#177 for details. This should land in controller-runtime soonish.