Adjust resource requests #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With just 20Mi request/30Mi limits, my instance of the wave controller running in a Kubernetes cluster with only ~50 pods never really started. It was already stuck at the log line `Starting metrics server`. Running the application locally in the debugger worked fine. The issue turned out to be starvation in garbage collection. Slightly increasing the memory requests resolved the issue entirely. Experiments allowed stable (but slow) operations starting with 40Mi requests/limits; with 75Mi wave starts and performs required operations within few seconds. Proposing to set request=limit to get into guaranteed QoS class.
|
Hi @JensErat. Thanks for your PR. I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
JoelSpeed
approved these changes
Aug 27, 2019
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With just 20Mi request/30Mi limits, my instance of the wave controller running in a Kubernetes cluster with only ~50 pods never really started. It was already stuck at the log line
Starting metrics server.Running the application locally in the debugger worked fine. The issue turned out to be starvation in garbage collection. Slightly increasing the memory requests resolved the issue entirely.
Experiments allowed stable (but slow) operations starting with 40Mi requests/limits; with 75Mi wave starts and performs required operations within few seconds. Proposing to set request=limit to get into guaranteed QoS class.