Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom tracing port #479

Merged
merged 7 commits into from
Jan 18, 2020
Merged

custom tracing port #479

merged 7 commits into from
Jan 18, 2020

Conversation

djia-vm-wf
Copy link
Contributor

No description provided.

@basilisk487
Copy link
Contributor

Also, needs unit tests (now every pipeline has its own unit tests). It's possible to do that without any thread sleeps - take a look at how delta counter aggregator is tested now.

basilisk487
basilisk487 approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@basilisk487 basilisk487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sushantdewan123 sushantdewan123 merged commit 05d3af6 into master Jan 18, 2020
@basilisk487 basilisk487 deleted the djia/PUB-186 branch April 4, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantdewan123 sushantdewan123 sushantdewan123 approved these changes

@basilisk487 basilisk487 basilisk487 approved these changes

@srujann srujann srujann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djia-vm-wf @basilisk487 @sushantdewan123 @srujann