Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

externalise the WM version number #72

Closed
wmrnaresh opened this issue Nov 28, 2019 · 4 comments
Closed

externalise the WM version number #72

wmrnaresh opened this issue Nov 28, 2019 · 4 comments
Assignees
@sharathpc

Comments

@wmrnaresh
Copy link
Contributor

Move the hardcoded WM build number out of the repo and read it from the environment.
@wmrnaresh
Copy link
Contributor Author

How to access the variables in .md files. facebook/docusaurus#395

Might have to write a plugin to integrate the WM build number into the markdown file.

@prasanth-reddy-wavemaker-com
Copy link
Contributor

This is good. Then new version deployments don't need code changes.

@rnaresh
Copy link
Contributor

rnaresh commented Nov 29, 2019

@sharath0033 started working on this

sharathpc added a commit that referenced this issue Dec 3, 2019
@sharathpc
Externalized WM version number to environment variable with custom re…
c5e48e0 
…markable plugin #72
sharathpc added a commit that referenced this issue Dec 5, 2019
@sharathpc
Externalized WM version number to env variable with custom job to rep…
940436a 
…lace variables after build #72
prasanth-reddy-wavemaker-com added a commit that referenced this issue Dec 6, 2019
@prasanth-reddy-wavemaker-com
Merge pull request #88 from wavemaker/variablereplacement
3af7bf1 
Externalized WM version number to env variable with custom job to replace variables after build #72
@rnaresh
Copy link
Contributor

rnaresh commented Dec 6, 2019

Added support for WM version umber

@rnaresh rnaresh closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharathpc sharathpc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rnaresh @sharathpc @wmrnaresh @prasanth-reddy-wavemaker-com