Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NODE-2619 Feature activation fixes #3900

Merged
merged 5 commits into from
Oct 20, 2023
Merged

NODE-2619 Feature activation fixes #3900

merged 5 commits into from
Oct 20, 2023

Conversation

vsuharnikov
Copy link
Member

  • Fixed a logic with rollbacks;
  • Small optimizations (don't read features each time from DB);
  • New tests.

@vsuharnikov vsuharnikov marked this pull request as ready for review October 18, 2023 06:36
@vsuharnikov vsuharnikov requested a review from phearnot as a code owner October 18, 2023 06:36
@vsuharnikov
Updated tests:
cfdfde3 
- edge cases for appending and rollbacks;
- getNextTestBlock instead of getNextTestBlockWithVotes if there are no votes.
@phearnot phearnot merged commit e311af4 into version-1.4.x Oct 20, 2023
1 check passed
@phearnot phearnot deleted the NODE-2619 branch October 20, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrtm000 xrtm000 xrtm000 approved these changes

@ivan-mashonskiy ivan-mashonskiy ivan-mashonskiy approved these changes

@DrBlast DrBlast DrBlast approved these changes

@phearnot phearnot phearnot approved these changes

@irina-pereiaslavskaia irina-pereiaslavskaia Awaiting requested review from irina-pereiaslavskaia

@goodmai goodmai Awaiting requested review from goodmai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsuharnikov @phearnot @DrBlast @ivan-mashonskiy @xrtm000