NODE-2616 Refactored validation of transaction version #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phearnot
requested changes
Nov 6, 2023
| @@ -1,11 +1,19 @@ | |||
| package com.wavesplatform.transaction | |||
|
|
|||
| trait VersionedTransaction { | |||
| def version: TxVersion | |||
| val version: TxVersion | |||
| val maxVersion: TxVersion | |||
There was a problem hiding this comment.
Moving maxVersion to TransactionType would better reflect the reality, since max version is a property of transaction type, rather than some particular transaction
vsuharnikov
approved these changes
Nov 10, 2023
…factored-tx-version-validation
ivan-mashonskiy
approved these changes
Nov 15, 2023
DrBlast
approved these changes
Nov 16, 2023
phearnot
requested changes
Nov 28, 2023
| @@ -1,11 +1,13 @@ | |||
| package com.wavesplatform.transaction | |||
|
|
|||
| trait VersionedTransaction { | |||
| def version: TxVersion | |||
| sealed trait VersionedTransaction { | |||
There was a problem hiding this comment.
Suggested change
| sealed trait VersionedTransaction { | |
| sealed trait VersionedTransaction { | |
| def version: TxVersion | |
| protected def maxVersion: TxVersion | |
| def isVersionValid: Boolean = 0 < version && version <= maxVersion | |
| } | |
| object VersionedTransaction { | |
| trait OnlyV1 extends VersionedTransaction { | |
| override val version: TxVersion = TxVersion.V1 | |
| override val maxVersion: TxVersion = TxVersion.V1 | |
| } | |
| trait ToV2 extends VersionedTransaction { | |
| override val maxVersion: TxVersion = TxVersion.V2 | |
| } | |
| trait ToV3 extends VersionedTransaction { | |
| override val maxVersion: TxVersion = TxVersion.V3 | |
| } | |
| } |
…factored-tx-version-validation
phearnot
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.