-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NODE-2625 Fixed GRPC Reflection API #3910
Conversation
@@ -263,7 +263,7 @@ class Docker( | |||
val containerConfig = ContainerConfig | |||
.builder() | |||
.image(imageName) | |||
.exposedPorts(s"$internalDebuggerPort") | |||
.exposedPorts(if (Try(nodeConfig.getStringList("waves.extensions").contains("com.wavesplatform.events.BlockchainUpdates")).getOrElse(false)) "6881" else s"$internalDebuggerPort") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This completely replaces port mapping when BU is enabled, which means one will not be able to debug the node inside the container. Please change this to always expose debug port, and expose BU port as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
No description provided.