Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE-2625 Fixed GRPC Reflection API #3910

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

xrtm000
Copy link
Member

@xrtm000 xrtm000 commented Nov 1, 2023

No description provided.

@xrtm000 xrtm000 marked this pull request as ready for review November 1, 2023 11:35
@@ -263,7 +263,7 @@ class Docker(
val containerConfig = ContainerConfig
.builder()
.image(imageName)
.exposedPorts(s"$internalDebuggerPort")
.exposedPorts(if (Try(nodeConfig.getStringList("waves.extensions").contains("com.wavesplatform.events.BlockchainUpdates")).getOrElse(false)) "6881" else s"$internalDebuggerPort")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This completely replaces port mapping when BU is enabled, which means one will not be able to debug the node inside the container. Please change this to always expose debug port, and expose BU port as needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@xrtm000 xrtm000 requested a review from phearnot November 7, 2023 08:17
@phearnot phearnot merged commit 069e969 into version-1.4.x Nov 7, 2023
1 check passed
@phearnot phearnot deleted the node-2625-grpc-reflection-api-error branch November 7, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants