Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Doesn't trigger microphone permission on macOS #1086

Closed
1 of 3 tasks
CallMeLaNN opened this issue Oct 21, 2024 · 5 comments
Closed
1 of 3 tasks

[Bug]: Doesn't trigger microphone permission on macOS #1086

CallMeLaNN opened this issue Oct 21, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@CallMeLaNN
Copy link

Current Behavior

I was running pyaudio to record voice but it doesn't work and .wav produced have empty bytes. I thought my installation or pyaudio issue but now I realize the terminal issue. I can record audio with default Terminal app.

Latest Wave app doesn't trigger microphone permission just like Terminal when using pyaudio.open(input=True,...).

Instead of I give a pyaudio script, you can try sox.

Expected Behavior

Prompt the mic permission and have audio stream recorded

Steps To Reproduce

  1. brew install sox
  2. sox -d -t wav - | play -
  3. Increase your volume
  4. Say something

After step 2, you should be prompted for the mic permission.
The you should hear yourself as you say with some echo for speaker.

Note: Use tccutil reset Microphone to let apps to ask for the permission again.

Wave Version

0.8.12

OS

macOS 12.6

Architecture

arm64

Anything else?

No response

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@CallMeLaNN CallMeLaNN added bug Something isn't working triage Needs triage labels Oct 21, 2024
@sawka
Copy link
Member

sawka commented Oct 25, 2024

Interesting. Thanks for reporting this. I haven't tried recording audio (or using the microphone) in Wave yet so we haven't run across this. It should be possible, like you said, to get that permission from the OS. Once we have a test case to work on we should be able to figure it out.

sawka added a commit that referenced this issue Nov 1, 2024
the permissions look scary, but the user still needs to grant them.  this just allows the app to ask.  this permission set now matches the entitlements in iTerm and other popular terminal programs (before we were too restrictive)
@sawka
Copy link
Member

sawka commented Nov 1, 2024

ah, my latest attempt worked! thanks for the instructions on how to test this. this should make the v0.9.1 build.
Screenshot 2024-11-01 at 1 04 31 PM

@CallMeLaNN
Copy link
Author

You are welcome. That's the least I can contribute to. Hope I can catchup with the 0.8 and 0.9 releases. I missed the 0.7 UI but 0.8 more productive and it wasn't auto update IIRC, so I'll watch here.

@esimkowitz
Copy link
Member

Hey @CallMeLaNN is this still an issue for you?

@esimkowitz esimkowitz removed the triage Needs triage label Nov 27, 2024
@CallMeLaNN
Copy link
Author

@esimkowitz Yup, its working. Mac ask for mic and I can hear myself.
Maybe I have to close this. Thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants