fix: bound custom fontsizes between 6 and 64

[oneirocosm]

Adds bounding for markdown (and AI) fontsize and fixedfontsize.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the frontend/app/element/markdown.tsx file, specifically addressing font size handling within the Markdown component. The primary change involves importing the boundNumber utility function from @/util/util, which is used to constrain font size values between 6 and 64 pixels.

The implementation updates the way font sizes are processed by applying the boundNumber function to fontSizeOverride and fixedFontSizeOverride properties. This ensures that font size values remain within a predefined range, preventing potential rendering issues with extreme or invalid font size settings.

The modification maintains the existing component structure and rendering logic, focusing solely on improving the robustness of font size value management. The import statement is expanded to include the boundNumber function, signaling a more controlled approach to handling numeric values within the component's styling logic.

These changes represent a targeted enhancement to the font size handling mechanism, introducing additional validation and constraint to the Markdown element's styling properties.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76e8bc4 and dcef646.

📒 Files selected for processing (1)

• frontend/app/element/markdown.tsx (2 hunks)

🔇 Additional comments (3)

frontend/app/element/markdown.tsx (3)

12-12: LGTM: Clean import addition

The boundNumber utility is appropriately imported alongside existing utilities.

---

383-386: Verify minimum font size bound: PR states 4px but code uses 6px

There's a discrepancy between the PR objectives (which mention a range of 4-64px) and the implementation (which uses 6-64px). While the implementation is functionally correct, we should ensure this difference is intentional.

-        mergedStyle["--markdown-font-size"] = `${boundNumber(fontSizeOverride, 6, 64)}px`;
+        mergedStyle["--markdown-font-size"] = `${boundNumber(fontSizeOverride, 4, 64)}px`;
-        mergedStyle["--markdown-fixed-font-size"] = `${boundNumber(fixedFontSizeOverride, 6, 64)}px`;
+        mergedStyle["--markdown-fixed-font-size"] = `${boundNumber(fixedFontSizeOverride, 4, 64)}px`;

Could you clarify if using 6px as the minimum (instead of 4px) was intentional? If not, I've provided a diff above to align with the PR objectives.

---

383-386: Verify consistent font size bounds across the codebase

Let's ensure these font size bounds are consistently applied wherever font sizes are manipulated.

✅ Verification successful

Font size bounds are consistently applied through a shared utility function

The codebase shows consistent usage of font size bounds through the boundNumber utility function. The implementation in frontend/app/element/markdown.tsx follows the same pattern used elsewhere in the application:

• The boundNumber function is defined in frontend/util/util.ts and used consistently across the codebase
• Both --markdown-font-size and --markdown-fixed-font-size use the same bounds (6-64px)
• The function properly handles validation and edge cases

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other instances of font size manipulation in CSS/SCSS files
rg -t css -t scss "font-size|--markdown-font-size|--markdown-fixed-font-size"

# Search for other potential uses of boundNumber with font sizes
rg "boundNumber.*font.*size"

Length of output: 139

---

Script:

#!/bin/bash
# Search for font size related patterns in all files
rg "font-size|--markdown-font-size|--markdown-fixed-font-size"

# Search for boundNumber function usage and definition
rg "boundNumber" -A 2

# Search for font size related CSS variables
ast-grep --pattern 'var(--markdown-font-size)'
ast-grep --pattern 'var(--markdown-fixed-font-size)'

Length of output: 117019

---

Script:

#!/bin/bash
# Search for font size related CSS variables and their usage
rg "font-size|--markdown-font-size|--markdown-fixed-font-size" frontend/

# Search for boundNumber function definition and usage
rg "boundNumber" frontend/ -A 3

Length of output: 12180

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.