-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi index again #326
Merged
Merged
Multi index again #326
+536
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usage This commit introduces a robust mechanism for maintaining consistent sequence ID assignments during wfmash index creation and usage. Key changes include: - Added export/import methods for sequence ID mappings in SequenceIdManager - Modified addSequence to use a nextId counter for new sequences - Updated index header reading/writing to preserve sequence ID information - Ensured sequence ID consistency across different runs and filtering scenarios The implementation allows: - Preserving original sequence IDs when creating/using indexes - Adding new sequences without disrupting existing ID assignments - Handling cases with multiple input files and sequence subsets Resolves potential mapping issues when working with complex sequence sets.
This commit enhances the robustness of sequence ID management by: 1. Adding more detailed error messages for missing sequences 2. Improving ID mapping import and merging 3. Adding prefix-based sequence filtering 4. Providing better logging for sequence-related issues
…ory-efficient subset handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and improves index saving and loading, and also target subset (
wfmash -b
) index building and loading.