Use dot #3
Open
Use dot #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wayneparrott I submit a draft PR base on your branch |
minggangw
force-pushed
the
service_introspection
branch
from
da157f4 to
ca61670
Compare
minggangw
commented
Apr 24, 2023
Comment on lines
-261
to
-269
| await Promise.all([ | ||
| ...pkg.messages.map((messageInfo) => | ||
| generateMessageJSStruct(messageInfo, dir) | ||
| ), | ||
| ...pkg.services.map((serviceInfo) => | ||
| generateServiceJSStruct(serviceInfo, dir) | ||
| ), | ||
| ...pkg.actions.map((actionInfo) => generateActionJSStruct(actionInfo, dir)), | ||
| ]); |
There was a problem hiding this comment.
I found this regression introduced by RobotWebTools#726, it caused the test fails because the JS message files haven't been generated yet when the npm test starts. I think we need to roll out this fix asap.
We need to put all the Promises into an arry here and pass it to Promise.all()
|
The case below is starting to fail consistently on the rolling build, haven't looked into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.