Skip to content

Commit

Permalink
Fix a11y issues with cross cluster replication flyouts (elastic#149069)
Browse files Browse the repository at this point in the history
Fixes elastic#135503, fixes
elastic#135506

## Summary

This PR fixes the a11y issues in the Follower index flyout and the Auto
follower index flyout from the Cross cluster replication plugin.

Screenshots:
<img height="500" alt="Screenshot 2023-01-17 at 17 46 08"
src="https://user-images.githubusercontent.com/59341489/212985332-794a2b7e-3e12-4303-bcbd-ad63552f211c.png">
<img height="500" alt="Screenshot 2023-01-17 at 13 26 51"
src="https://user-images.githubusercontent.com/59341489/212987803-40062d53-3b34-4286-98fc-736264491b08.png">


Followed [these
instructions](https://www.elastic.co/guide/en/elasticsearch/reference/current/ccr-getting-started-tutorial.html#ccr-getting-started-tutorial)
to set up the cross cluster replication and the follower and
auto-follower indices.


### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
2 people authored and wayneseymour committed Jan 19, 2023
1 parent 9f177c0 commit 9fd5b10
Show file tree
Hide file tree
Showing 4 changed files with 186 additions and 157 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,10 @@ describe('<AutoFollowPatternList />', () => {
test('should have a "settings" section', () => {
actions.clickAutoFollowPatternAt(0);
expect(find('settingsSection').find('h3').text()).toEqual('Settings');
expect(exists('settingsValues')).toBe(true);

// The number of different settings of an auto-follower pattern
const AVAILABLE_SETTINGS = 4;
expect(find('settingsValues').length).toBe(AVAILABLE_SETTINGS);
});

test('should set the correct auto-follow pattern settings values', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ export class DetailPanel extends Component {

<EuiSpacer size="s" />

<EuiDescriptionList data-test-subj="settingsValues">
<EuiFlexGroup>
<EuiFlexItem>
<EuiFlexGroup>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -117,9 +117,11 @@ export class DetailPanel extends Component {
<EuiDescriptionListDescription data-test-subj="remoteCluster">
{remoteCluster}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiDescriptionList>
</EuiFlexItem>

<EuiFlexItem>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -132,13 +134,15 @@ export class DetailPanel extends Component {
<EuiDescriptionListDescription data-test-subj="leaderIndexPatterns">
{leaderIndexPatterns.join(', ')}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiFlexGroup>
</EuiDescriptionList>
</EuiFlexItem>
</EuiFlexGroup>

<EuiSpacer size="s" />
<EuiSpacer size="s" />

<EuiFlexGroup>
<EuiFlexItem>
<EuiFlexGroup>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -158,9 +162,11 @@ export class DetailPanel extends Component {
</em>
)}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiDescriptionList>
</EuiFlexItem>

<EuiFlexItem>
<EuiFlexItem>
<EuiDescriptionList data-test-subj="settingsValues">
<EuiDescriptionListTitle>
<EuiTitle size="xs">
<FormattedMessage
Expand All @@ -180,9 +186,9 @@ export class DetailPanel extends Component {
</em>
)}
</EuiDescriptionListDescription>
</EuiFlexItem>
</EuiFlexGroup>
</EuiDescriptionList>
</EuiDescriptionList>
</EuiFlexItem>
</EuiFlexGroup>
</section>
</>
);
Expand Down
Loading

0 comments on commit 9fd5b10

Please sign in to comment.