New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved packaging #7

Open

sachahu1 wants to merge 1 commit into wayveai:main from sachahu1:feat/packaging

sachahu1 commented Nov 21, 2024

First off, thanks for publishing the dataset - it’s really great!

Is this PR something you'd consider? It uses poetry to package the project which adds a lot of benefits:

Ability to install from source: pip install git+https://github.com/sachahu1/wayve_scenes.git@feat/packaging
Ability to easily build a wheel (and publish to PyPi): poetry build && poetry publish
Bundles the download.sh script into the wheel meaning you can now pip install wayve_scenes && download.sh without the need to clone the repo or fetch the script.

I believe this should also simplify the conda install route.


          feat: poetry packaging

Package using poetry to easily build wheels, install from source and bundle download script

sachahu1 mentioned this pull request

Package with pyproject toml and standard setuptools #8

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet