Wazo 3442 phonebook source name auto

wazo_dird/database/models.py

@@ -1,11 +1,11 @@
-# Copyright 2016-2023 The Wazo Authors (see the AUTHORS file)
+# Copyright 2016-2024 The Wazo Authors (see the AUTHORS file)
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 from sqlalchemy import Column, ForeignKey, Integer, Sequence, String, Text, schema, text
 from sqlalchemy.dialects.postgresql import ARRAY, HSTORE, JSON, UUID
 from sqlalchemy.ext.associationproxy import association_proxy
 from sqlalchemy.ext.declarative import declarative_base
-from sqlalchemy.orm import relationship
+from sqlalchemy.orm import relationship, validates
 
 Base = declarative_base()
 
@@ -263,6 +263,21 @@ class Source(Base):
  lambda: Phonebook, foreign_keys=[phonebook_uuid], lazy='joined'
  )
 
+ @validates('name')
+ def ensure_phonebook_name(self, key, value):
+ assert key == 'name'
+ if not self.backend == 'phonebook':
+ return value
+ else:
+ assert self.phonebook_uuid and self.phonebook
+ if self.phonebook.name == value:
+ return value
+ else:
+ raise ValueError(
+ f'Source name {value} does not correspond to underlying '
+ f'phonebook name {self.phonebook.name}'
+ )
+
 
 class Tenant(Base):
  __tablename__ = 'dird_tenant'

wazo_dird/plugins/phonebook_backend/api.yml

@@ -65,7 +65,7 @@ paths:
  - $ref: '#/parameters/tenantuuid'
  - name: body
  in: body
- description: The display configuration body
+ description: The phonebook source configuration body
  required: true
  schema:
  $ref: '#/definitions/PhonebookSource'
@@ -152,14 +152,18 @@ definitions:
  allOf:
  - $ref: '#/definitions/Source'
  - properties:
+ name:
+ readOnly: true
  phonebook_uuid:
  type: string
+ readOnly: true
  phonebook_name:
  type: string
+ readOnly: true
  phonebook_description:
  type: string
+ readOnly: true
  - required:
- - name
  - phonebook_uuid
  PhonebookSourceItems:
  title: PhonebookSourceItems

wazo_dird/plugins/phonebook_backend/schemas.py

@@ -6,7 +6,7 @@
 from typing import TypedDict
 
 from marshmallow import post_load
-from xivo.mallow import fields
+from xivo.mallow import fields, validate
 from xivo.mallow_helpers import ListSchema as _ListSchema
 
 from wazo_dird.schemas import BaseSourceSchema
@@ -16,6 +16,7 @@ class SourceSchema(BaseSourceSchema):
  phonebook_uuid = fields.UUID(required=True)
  phonebook_name = fields.String(dump_only=True)
  phonebook_description = fields.String(dump_only=True)
+ name = fields.String(validate=validate.Length(min=1, max=512), dump_only=True)
 
  @post_load
  def stringify_uuid(self, data, **kwargs):