fix: PR comments

src/common/CMakeLists.txt

@@ -1,8 +1,10 @@
 add_subdirectory(binaries_op)
+add_subdirectory(bzip2_op)
 add_subdirectory(config)
 add_subdirectory(data_provider)
 add_subdirectory(dbsync)
 add_subdirectory(error_messages)
+add_subdirectory(file_op)
 add_subdirectory(filesystem_wrapper)
 add_subdirectory(hashHelper)
 add_subdirectory(logger)

src/common/bzip2_op/CMakeLists.txt

@@ -5,6 +5,7 @@ target_include_directories(bzip2_op PUBLIC include)
 
 target_link_libraries(bzip2_op
     error_messages
+    file_op
     Logger
     pal
     time_op

src/common/bzip2_op/src/bzip2_op.c

@@ -10,6 +10,7 @@
 #include <stdio.h>
 #include <errno.h>
 #include "bzip2_op.h"
+#include "file_op.h"
 #include "error_messages.h"
 #include "logger.hpp"
 

src/common/file_op/include/file_op.h

@@ -28,7 +28,10 @@
 #include <libproc.h>
 #endif
 
+#ifndef WIN32
 #define OS_PIDFILE  "var/run"
+#endif
+
 #define UCS2_LE 1
 #define UCS2_BE 2
 

src/common/file_op/src/file_op.c

@@ -14,6 +14,7 @@
 #include "shared.h"
 #include "version_op.h"
 #include "pal.h"
+#include "file_op.h"
 
 #include <zlib.h>
 

src/common/logger/include/logger.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <stdarg.h>
+#include <string.h>
 
 // Extract file name from path (inline function for C++ and macro for C)
 #ifdef __cplusplus

src/common/pal/tests/windows/CMakeLists.txt

@@ -4,4 +4,4 @@ add_executable(PalTime_test pal_time_test.cpp)
 configure_target(PalTime_test)
 target_include_directories(PalTime_test PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/../../include)
 target_link_libraries(PalTime_test PRIVATE pal GTest::gtest GTest::gtest_main)
-add_test(NAME PalTimeTest COMMAND PalTime_test)
+add_test(NAME PalTimeTest COMMAND PalTime_test)

src/common/utils/include/shared.h

@@ -104,7 +104,6 @@
 
 #include "defs.h"
 #include "os_err.h"
-#include "time_op.h"
 
 #include "os_ip.h"
 

src/common/version_op/src/version_op.c

@@ -171,7 +171,6 @@ os_info *get_win_version()
                 LogError("Error reading 'Current Version' from Windows registry. (Error %u)",(unsigned int)dwRet);
             }
             else {
-                // TODO: Solve when StrBreak is implemented
                 char ** parts = OS_StrBreak('.', winver, 2);
                 info->os_major = strdup(parts[0]);
                 info->os_minor = strdup(parts[1]);