Agent will operate with its default configuration out of the box #304
Conversation
aritosteles
requested review from
jr0me,
sdvendramini,
TomasTurina and
Nicogp
aritosteles
force-pushed
the
enhancement/285-default-settings
branch
2 times, most recently
from
3d9a378 to
5b8ca1f
Compare
There was a problem hiding this comment.
I'm not sure about the choice of interface for the default value, we are passing it all the way down to the configuration parser only to get it back if it can't find the requested key.
There's a similar end user case that you could achieve by changing the returned type to an optional, see https://en.cppreference.com/w/cpp/utility/optional/value_or .
Instead of T GetConfig(T defaultValue, Keys... keys) const and passing the default value all the way down, you can do std::optional<T> GetConfig(Keys... keys) and when used configurationParser.GetConfig<int>("table", "key").value_or(DEFAULT_VALUE_FOR_KEY).
src/agent/configuration_parser/tests/configuration_parser_test.cpp
Outdated
Show resolved
Hide resolved
aritosteles
force-pushed
the
enhancement/285-default-settings
branch
from
5b8ca1f to
c9a3b11
Compare
src/agent/configuration_parser/include/configuration_parser.hpp
Outdated
Show resolved
Hide resolved
src/agent/configuration_parser/tests/configuration_parser_test.cpp
Outdated
Show resolved
Hide resolved
| constexpr auto DEFAULT_RELOAD_INTERVAL = @DEFAULT_RELOAD_INTERVAL@; | ||
| namespace logcollector | ||
| { | ||
| constexpr auto BUFFER_SIZE = @BUFFER_SIZE@; |
There was a problem hiding this comment.
Note: In the future we need to evaluate if this setting should also be included in the wazuh-agent.yml file.
aritosteles
force-pushed
the
enhancement/285-default-settings
branch
2 times, most recently
from
168cca8 to
b5c3682
Compare
Also corresponding changes in agent.cpp and CMakeLists.txt
aritosteles
force-pushed
the
enhancement/285-default-settings
branch
from
b5c3682 to
c53ec86
Compare
Description
This PR aims to allow the agent to use default settings in case some or all settings are not specified in the configuration file or if the configuration file does not exist.
Configuration options
Logs/Alerts example
Tests