Fix Agent Registration Behavior

[vikman90]

Summary

This pull request addresses two issues:

• Agent Saves Registration Information Even on Failure #314
• Agent Registration Fails Due to 201 Status Code #318

Changes

• Database Handling:
  • Refactored the AgentInfo component to delay database writes until registration is confirmed.
  • Introduced a Save() method to persist data only after successful registration.
• Registration Status Code:
  Modified the expected status code for registration responses from 200 to 201.

Tests

• AgentInfo Tests:
  • Updated existing tests to validate the new behavior of Set() and Save().
  • Verified that database writes only occur after Save() is called.
• AgentRegistration Tests:
  • Adapted tests to account for the 201 status code as a success indicator.
  • Ensured the agent correctly interprets 201 and does not fail the registration process.
• Manual Testing:
  • Tested with a mock server using Imposter: Test Wazuh Agent with Mock Server Using Docker and Imposter #281
    • Verified that 201 responses result in successful registration.
    • Confirmed that the database remains unmodified in cases of registration failure.

Important

In this change, we simplify the RegistrationTestSuccessWithEmptyKey test, since this test makes the agent produce a random key. Since persistence is removed, the mock does not have access to the new key. However, the persistence behavior of AgentRegistration is checked in RegistrationSuccess.

Manual testing

Registration failure

./wazuh-agent --config-file wazuh-agent.yml --register-agent --user wazuh --password topsecret --name other

Failed to authenticate with the manager
wazuh-agent registration failed

sqlite3 agent_info.db 'select * from agent_info'

||

Registration success

./wazuh-agent --config-file wazuh-agent.yml --register-agent --user wazuh --password topsecret --name dummy

wazuh-agent registered

sqlite3 agent_info.db 'select * from agent_info'

dummy|vEcz2euGDR2mTAxn4Fu6KrCIOhmsfq7U|114563d6-a9ae-4aec-aa58-7f0ee0500bab

[jr0me]

LGTM.

Maybe the tests need improvement, I'm not sure about the changes introduced, but it looks like we are losing some checks there.