-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add messages batch size and interval options #377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr0me
changed the title
Add batching size and interval options
Add messages batch size and interval options
Dec 2, 2024
TomasTurina
reviewed
Dec 2, 2024
TomasTurina
reviewed
Dec 2, 2024
TomasTurina
reviewed
Dec 2, 2024
jr0me
force-pushed
the
enhancement/306-batching-options
branch
3 times, most recently
from
December 2, 2024 22:45
2d52235
to
8ac4d24
Compare
jr0me
force-pushed
the
enhancement/306-batching-options
branch
2 times, most recently
from
December 2, 2024 22:48
558e797
to
e1013b0
Compare
jr0me
force-pushed
the
enhancement/306-batching-options
branch
3 times, most recently
from
December 3, 2024 00:24
9cdfd58
to
f7b34fd
Compare
jr0me
force-pushed
the
enhancement/306-batching-options
branch
from
December 3, 2024 00:28
f7b34fd
to
7fc6789
Compare
get messages callback will now take an int parameter for the batch size
jr0me
force-pushed
the
enhancement/306-batching-options
branch
from
December 3, 2024 00:29
7fc6789
to
410da58
Compare
TomasTurina
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements configurable batching for the Wazuh Agent to improve flexibility in how it sends messages to the server. Previously, the agent sent batches of messages every second without considering the batch size or the time elapsed. With this change, the batching process is governed by two configurable conditions:
A batch is sent if the specified batch_interval has elapsed and the queue contains messages.
A batch is sent if the queue accumulates batch_size messages before batch_interval elapses.
These conditions ensure:
Tests