Fix race condition associated to module reload and modulemanager #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasTurina
approved these changes
Dec 16, 2024
Since commands may require ReloadModules to be called, and they are run from coroutines, which can happen on different threads, we need a way to limit when such calls can happen. ReloadModules will now be permitted only while the Agent has finished starting up, and up until a signal is received to shutdown. For this a mutex and a flag have been added. Also the TaskManager::Start call has been moved to the Run() method. Because of this, m_agentThreadCount had to be created.
Also, return from Start only when each task queued into the task manager has been called.
jr0me
force-pushed
the
fix/432-race-condition-associated-to-module-reload-and-modulemanager
branch
from
8361d8f to
87e13d4
Compare
vikman90
deleted the
fix/432-race-condition-associated-to-module-reload-and-modulemanager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the issue, the possibility of reloading modules requires some mechanism to avoid race conditions, in particular that the Agent stops the module manager when shutting down right before a ReloadModules command is received, resulting in two
ModuleManager::Stopcalls followed by aModuleManager::Starthalting the application.The changes introduced by this PR are focused on improving thread safety and control mechanisms within the Wazuh Agent.
Tests