Add server certificate validation to wazuh agent #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogp
force-pushed
the
enhancement/389-add-server-certificate-validation-to-wazuh-agent
branch
from
f7d9753 to
2e7d6af
Compare
Nicogp
force-pushed
the
enhancement/389-add-server-certificate-validation-to-wazuh-agent
branch
from
2e7d6af to
967804a
Compare
TomasTurina
reviewed
Dec 19, 2024
| @@ -32,6 +33,7 @@ namespace http_client | |||
| const std::string& serverUrl, | |||
| std::string endpoint, | |||
| std::string userAgent, | |||
| std::string verificationMode, | |||
TomasTurina
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Add tests for certificate and none cases.
TomasTurina
reviewed
Dec 19, 2024
| @@ -30,7 +31,7 @@ void RegisterAgent(const std::string& url, | |||
| agent_registration::AgentRegistration reg(url, user, password, key, name, dbFolderPath); | |||
|
|
|||
| http_client::HttpClient httpClient; | |||
| if (reg.Register(httpClient)) | |||
| if (reg.Register(httpClient, verificationMode)) | |||
There was a problem hiding this comment.
I wonder why you didn't choose to add an m_verificationMode data member in the AgentRegistration class.
Although I like it better this way because it makes the Register function easier to test.
TomasTurina
reviewed
Dec 19, 2024
… agent and windows agent
Nicogp
force-pushed
the
enhancement/389-add-server-certificate-validation-to-wazuh-agent
branch
from
bc909d7 to
76efee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds server certificate validation.
For server connections when the agent is already registered, a new configuration option is added to control which mode will be used:
Possible Values:
To perform the registration of the agent, a new option was added to the CLI “--verification-mode”, the values that can take are the same as for the previous case:
wazuh-agent --register-agent --user user --password pass --url https://serverIP:55000 --verification-mode certificateTests