-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize Empty and Invalid Data in Inventory #446
Merged
vikman90
merged 10 commits into
master
from
enhancement/411-normalize-empty-and-invalid-data-in-inventory
Jan 10, 2025
Merged
Normalize Empty and Invalid Data in Inventory #446
vikman90
merged 10 commits into
master
from
enhancement/411-normalize-empty-and-invalid-data-in-inventory
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbertoldo
force-pushed
the
enhancement/411-normalize-empty-and-invalid-data-in-inventory
branch
2 times, most recently
from
January 6, 2025 12:32
707b0b5
to
2e64068
Compare
nbertoldo
force-pushed
the
enhancement/411-normalize-empty-and-invalid-data-in-inventory
branch
from
January 6, 2025 21:51
2e64068
to
0784357
Compare
nbertoldo
requested review from
cborla,
LucioDonda and
ncvicchi
and removed request for
cborla and
LucioDonda
January 9, 2025 20:50
nbertoldo
force-pushed
the
enhancement/411-normalize-empty-and-invalid-data-in-inventory
branch
from
January 9, 2025 20:55
cd732f7
to
e7dc1cc
Compare
cborla
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vikman90
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vikman90
deleted the
enhancement/411-normalize-empty-and-invalid-data-in-inventory
branch
January 10, 2025 11:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of the inventory system has inconsistencies in how empty data and invalid values are handled. This PR standardizes data representation and validation, ensuring cleaner and more reliable outputs.
Report Empty Data as Null
null
in the output JSON.“ ”
or any other placeholders used as empty data are removed.Validate Data Types
Define Inventory Specification
Tests