Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Empty and Invalid Data in Inventory #446

Merged

Conversation

nbertoldo
Copy link
Member

@nbertoldo nbertoldo commented Dec 19, 2024

Related issue
#411

Description

The current implementation of the inventory system has inconsistencies in how empty data and invalid values are handled. This PR standardizes data representation and validation, ensuring cleaner and more reliable outputs.

Report Empty Data as Null

  • Fields that the system could not collect are represented as null in the output JSON.
  • Spaces “ ” or any other placeholders used as empty data are removed.

Validate Data Types

  • All data provided by DataProvider strictly adheres to the defined types (e.g., array, date, number, string, etc.).

Define Inventory Specification

  • All fields reported by the inventory module comply with the specifications of the indexer documentation.

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X

@nbertoldo nbertoldo linked an issue Dec 19, 2024 that may be closed by this pull request
@nbertoldo nbertoldo force-pushed the enhancement/411-normalize-empty-and-invalid-data-in-inventory branch 2 times, most recently from 707b0b5 to 2e64068 Compare January 6, 2025 12:32
@nbertoldo nbertoldo force-pushed the enhancement/411-normalize-empty-and-invalid-data-in-inventory branch from 2e64068 to 0784357 Compare January 6, 2025 21:51
@nbertoldo nbertoldo marked this pull request as ready for review January 9, 2025 20:50
@nbertoldo nbertoldo requested review from cborla, LucioDonda and ncvicchi and removed request for cborla and LucioDonda January 9, 2025 20:50
@nbertoldo nbertoldo force-pushed the enhancement/411-normalize-empty-and-invalid-data-in-inventory branch from cd732f7 to e7dc1cc Compare January 9, 2025 20:55
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vikman90 vikman90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

Revision

LGTM

@vikman90 vikman90 merged commit f5f4eed into master Jan 10, 2025
5 checks passed
@vikman90 vikman90 deleted the enhancement/411-normalize-empty-and-invalid-data-in-inventory branch January 10, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize Empty and Invalid Data in Inventory
3 participants