Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some PAL related issues #464

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix some PAL related issues #464

merged 2 commits into from
Dec 23, 2024
+1 −2

Conversation

ncvicchi
Copy link
Member

@ncvicchi ncvicchi commented Dec 23, 2024 •
edited
Loading

Description

This PR fixes 2 problems encounted with the PAL implementation.

  • It fixes PAL availability when source code is compile with syscollector or inventory turned off
  • It removes strtor_r definitions for macOS and Linux since they are unnecessary and create warnings.
Related issue
#463

Description

Configuration options

Logs/Alerts example

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Source installation
  • Package installation
  • Source upgrade
  • Package upgrade
  • Review logs syntax and correct language
  • QA templates contemplate the added capabilities
  • Memory tests for Linux
    • Scan-build report
    • Coverity
    • Valgrind (memcheck and descriptor leaks check)
    • Dr. Memory
    • AddressSanitizer
  • Memory tests for Windows
    • Scan-build report
    • Coverity
    • Dr. Memory
  • Memory tests for macOS
    • Scan-build report
    • Leaks
    • AddressSanitizer
  • Retrocompatibility with older Wazuh versions
  • Working on cluster environments
  • Configuration on demand reports new parameters
  • The data flow works as expected (agent-manager-api-app)
  • Added unit tests (for new features)
  • Stress test for affected components
  • Decoder/Rule tests
    • Added unit testing files ".ini"
    • runtests.py executed without errors

@ncvicchi ncvicchi self-assigned this Dec 23, 2024
@ncvicchi ncvicchi changed the title Removed unnecesary strtok_r definitions Fix some PAL related issues Dec 23, 2024
@ncvicchi ncvicchi added level/task Task issue module/inventory Inventory module mvp Minimum Viable Product refinement labels Dec 23, 2024
LucioDonda
LucioDonda approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@LucioDonda LucioDonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TomasTurina TomasTurina merged commit 41f2fb2 into master Dec 23, 2024
5 checks passed
@TomasTurina TomasTurina deleted the fix/remove_strtok_r_redefinition branch December 23, 2024 19:05
@TomasTurina TomasTurina linked an issue Dec 23, 2024 that may be closed by this pull request
Remove strtok_r warning when RPM package is generated #463
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioDonda LucioDonda LucioDonda approved these changes

@TomasTurina TomasTurina TomasTurina approved these changes

@MarcelKemp MarcelKemp Awaiting requested review from MarcelKemp

@Nicogp Nicogp Awaiting requested review from Nicogp

Assignees

@ncvicchi ncvicchi

Labels
level/task Task issue module/inventory Inventory module mvp Minimum Viable Product refinement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove strtok_r warning when RPM package is generated
3 participants
@ncvicchi @TomasTurina @LucioDonda