Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert agent and manager configuration only once #47

Closed
wants to merge 1 commit into from
Closed

Assert agent and manager configuration only once #47

wants to merge 1 commit into from

Conversation

madonius
Copy link

@madonius madonius commented Aug 8, 2018

Save some time by reducing the checks

Assert agent and manager configuration only once
22c2956 
Assert if java needs to be installed or if the configuration is beeing disabled only once, in a block
@cadoming cadoming self-requested a review October 24, 2018 11:38
cadoming
cadoming approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@cadoming cadoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madonius thanks for you colaboration, it works fine. I will reply this changes to another branch for merging them into the 3.7 branch when it release.

@cadoming cadoming mentioned this pull request Oct 31, 2018
Merged
@cadoming
Copy link
Contributor

Hi @madonius,

First of all, thanks for your work. We have created the PR #74 to add your changes with the new structure of the branch 3.7.

@cadoming cadoming closed this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadoming cadoming cadoming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madonius @cadoming