Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix agent enrollment default value. Fix authd registration. #505

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Fix agent enrollment default value. Fix authd registration. #505

merged 6 commits into from
Nov 23, 2020

Conversation

Zenidd
Copy link
Contributor

@Zenidd Zenidd commented Nov 20, 2020 •
edited
Loading

Hi team,

This PR sets enrollment to enabled by default.
This PR fixes authd registration verification.
This PR solves #502

Greetings,

JP

@Zenidd Zenidd requested review from xr09, manuasir and neonmei November 20, 2020 13:17
@Zenidd Zenidd self-assigned this Nov 20, 2020
neonmei
neonmei approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@neonmei neonmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zenidd Zenidd changed the base branch from 4.0 to master November 23, 2020 13:29
neonmei
neonmei approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@neonmei neonmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Zenidd Zenidd mentioned this pull request Nov 23, 2020
Closed
@neonmei neonmei merged commit d7f7eb2 into master Nov 23, 2020
@neonmei neonmei deleted the fix-agent-enrollment-default branch November 23, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xr09 xr09 xr09 approved these changes

@neonmei neonmei neonmei approved these changes

@manuasir manuasir Awaiting requested review from manuasir

Assignees

@Zenidd Zenidd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zenidd @xr09 @neonmei