Skip to content

Commit

Permalink
Fix cannot read null properties bug in settings section (#5135)
Browse files Browse the repository at this point in the history
* fixed bug cannot read null properties in settings section

* changelog
  • Loading branch information
chantal-kelm authored Feb 17, 2023
1 parent 7a5808e commit 4c113f7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ All notable changes to the Wazuh app project will be documented in this file.
- Fixed several typos in the code, by @jctello [#4911](https://github.com/wazuh/wazuh-kibana-app/pull/4911)
- Fixed the display of more than one protocol in the Global configuration section [#4917](https://github.com/wazuh/wazuh-kibana-app/pull/4917)
- Handling endpoint response was done when there is no data to show [#4918]https://github.com/wazuh/wazuh-kibana-app/pull/4918
- Fixed the 2 errors that appeared in console in Settings>Configuration section. [#5135](https://github.com/wazuh/wazuh-kibana-app/pull/5135)

## Wazuh v4.4.0 - Kibana 7.10.2, 7.16.x, 7.17.x - Revision 4400

Expand Down
17 changes: 8 additions & 9 deletions public/components/common/hooks/use-kbn-loading-indicator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Find more information about this on the LICENSE file.
*/
import { getHttp } from '../../../kibana-services';
import React, { useEffect, useState } from 'react';
import React, { useEffect, useState, useRef } from 'react';
import { BehaviorSubject } from 'rxjs';

export const useKbnLoadingIndicator = (): [
Expand All @@ -21,28 +21,27 @@ export const useKbnLoadingIndicator = (): [
const [loading, setLoading] = useState(false);
const [flag, setFlag] = useState(false);
const [visible, setVisible] = useState(0);

const loadingCount$ = new BehaviorSubject(0);

const loadingCount$ = useRef(new BehaviorSubject(0))

useEffect(() => {
getHttp().addLoadingCountSource(loadingCount$);
const { unsubscribe } = getHttp()
getHttp().addLoadingCountSource(loadingCount$.current);
const subscriber = getHttp()
.getLoadingCount$()
.subscribe((count) => {
setVisible(count);
!count && setFlag(false);
});
return unsubscribe;
return () => subscriber.unsubscribe();
}, []);

useEffect(() => {
if (loading && visible <= 0) {
loadingCount$.next(loadingCount$.value + 1);
loadingCount$.current.next(loadingCount$.current.value + 1);
setFlag(true);
}

if (!loading && flag && visible > 0) {
loadingCount$.next(loadingCount$.value - 1);
loadingCount$.current.next(loadingCount$.current.value - 1);
}
}, [visible, loading]);
return [loading, setLoading, visible > 0];
Expand Down

0 comments on commit 4c113f7

Please sign in to comment.