Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the agent info ribbon scroll with the rest of the content #4256

Closed
gdiazlo opened this issue Jun 14, 2022 · 2 comments · Fixed by #4516
Closed

Make the agent info ribbon scroll with the rest of the content #4256

gdiazlo opened this issue Jun 14, 2022 · 2 comments · Fixed by #4516
Assignees
Labels
type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side

Comments

@gdiazlo
Copy link
Member

gdiazlo commented Jun 14, 2022

Describe the solution you'd like

A user navitages to the agent overview page using a device with an uncommon resolution ( like a MS Surface) and it renders like this:

image

That render hasn´t been scrolled, but look like if it were scrolled to the bottom of the page.

We want to redesign the page so the ribbon with the agent status and information scrolls like the rest of the content.

@gdiazlo gdiazlo added the type/enhancement Enhancement issue label Jun 14, 2022
@gdiazlo gdiazlo moved this to Triage in Release 4.4.0 Jun 14, 2022
@gdiazlo gdiazlo moved this from Triage to Todo in Release 4.4.0 Aug 29, 2022
@vikman90 vikman90 added this to the Release 4.4.0 milestone Aug 31, 2022
@matiasmoreno876 matiasmoreno876 moved this from Todo to In Progress in Release 4.4.0 Sep 9, 2022
@matiasmoreno876
Copy link
Contributor

matiasmoreno876 commented Sep 14, 2022

Analyzing the code, it is found that the component that shows the agent details is public/components/common/welcome/agents-info.js

this component is used in public/components/common/welcome/agents-welcome.js

where the design problem is found

@matiasmoreno876 matiasmoreno876 linked a pull request Sep 14, 2022 that will close this issue
@wazuh wazuh deleted a comment from matiasmoreno876 Sep 16, 2022
@AlexRuiz7 AlexRuiz7 moved this from In Progress to On Hold in Release 4.4.0 Sep 19, 2022
@Tostti Tostti self-assigned this Sep 20, 2022
@Tostti Tostti moved this from On Hold to In Progress in Release 4.4.0 Sep 20, 2022
@Tostti Tostti moved this from In Progress to In Review in Release 4.4.0 Sep 21, 2022
@AlexRuiz7 AlexRuiz7 added UI/UX Generic label for things related to the font-end side UX labels Sep 22, 2022
@Tostti
Copy link
Member

Tostti commented Sep 22, 2022

Merged PR #4516 and the backports

@Tostti Tostti closed this as completed Sep 22, 2022
Repository owner moved this from In Review to Done in Release 4.4.0 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants