Modify agent overview page #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexRuiz7
suggested changes
Sep 21, 2022
Mayons95
approved these changes
Sep 21, 2022
|
I found a problem with the agent name, but reviewed with @Tostti we found that is not a particular behavior related with this PR, so I decided to put the evidence of the issue here to discuss if we can open a new issue to work on this.
|
4 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
* layout structures are modified * change styles to fix window * Fix visual errors * Change structure * Update changelog * Fix Changelog * Update CHANGELOG.md Co-authored-by: Nico Guevara <nicolas.guevara@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 309227b)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
* layout structures are modified * change styles to fix window * Fix visual errors * Change structure * Update changelog * Fix Changelog * Update CHANGELOG.md Co-authored-by: Nico Guevara <nicolas.guevara@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 309227b)
Tostti
pushed a commit
that referenced
this pull request
Sep 22, 2022
Modify agent overview page (#4516) * layout structures are modified * change styles to fix window * Fix visual errors * Change structure * Update changelog * Fix Changelog * Update CHANGELOG.md Co-authored-by: Nico Guevara <nicolas.guevara@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 309227b) Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com>
Tostti
pushed a commit
that referenced
this pull request
Sep 22, 2022
Modify agent overview page (#4516) * layout structures are modified * change styles to fix window * Fix visual errors * Change structure * Update changelog * Fix Changelog * Update CHANGELOG.md Co-authored-by: Nico Guevara <nicolas.guevara@wazuh.com> Co-authored-by: Nico Guevara <42900763+Tostti@users.noreply.github.com> Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 309227b) Co-authored-by: Matias Ezequiel Moreno <matiasmoreno876@gmail.com>
7 tasks
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4256
This PR will improve the Agent Overview view, fixing different issues found. All the changes were also tested in dark mode.
Main Issue
On some resolutions, the Agent's overview page rendered like this:
That render hasn´t been scrolled, but look like if it were scrolled to the bottom of the page.
Changes done
Removed the anchor to the agent details menu:
This change was done to fix the aforementioned issue. The Agent's detail is now another section on the main screen that will move on scroll, preventing padding problems when its size changes.
Before the changes:
Grabacion.de.pantalla.desde.20-09-22.15.45.22.mov
After the changes:
Grabacion.de.pantalla.desde.20-09-22.15.22.47.mov
Fixed menu buttons for small screens
This change was done to improve the experience when the App is used on a small screen, for example, from a mobile phone on vertical mode. Previously the menu wasn't displayed, and the agent name was unnecessarily trimmed.
Before the changes:
Grabacion.de.pantalla.desde.20-09-22.15.42.31.mov
After the changes:
Grabacion.de.pantalla.desde.20-09-22.15.23.36.mov
Tests
Scenario: Open the summary page for an agent
Given a screen width higher than 1360px
Then the elements should be shown without overlapping or issues
Scenario: Open the summary page for an agent
Given a screen width lower than 1360px and higher than 768px
Then the elements should be shown without overlapping or issues
Scenario: Open the summary page for an agent
Given a screen width lower than 768px
Then the elements should be shown without overlapping or issues