Improve alerts summary performance #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules without selected agent
Desvelao
reviewed
Aug 10, 2022
Desvelao
reviewed
Aug 10, 2022
server/lib/reporting/summary-tables-definitions/agents/index.ts
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Aug 10, 2022
Desvelao
reviewed
Aug 10, 2022
| width: 40 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| fim: { |
There was a problem hiding this comment.
nitpick: This file could be deprecated. We should check and remove it if it is not necessary anymore.
|
issue: There are some hidden visualizations in the dashboards, we should remove them. |
|
Needs performance comparative |
|
TR: ✔️ |
4 tasks
Mayons95
approved these changes
Sep 8, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Reduced alerts summary bucket size * Added Alerts Summary table class * Added Alerts Summary table class * Added base configuration tables * feat: add structures for aggregation queries of summary tables of modules without selected agent * Split extended information and added agents tables * Code cleaning * Added optional chaining to conditionals * Added missing alerts summary definitions * Delete hidden vis and fix merge conflicts * Fix merge * Add changelog Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 395fb8a)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-1.2-wzd 4.4-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-1.2-wzd
# Create a new branch
git switch --create backport-4376-to-4.4-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 395fb8a485e8bcac6f96a4fbc8dd07100f7dc2c7
# Push it to GitHub
git push --set-upstream origin backport-4376-to-4.4-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-1.2-wzdThen, create a pull request where the |
AlexRuiz7
pushed a commit
that referenced
this pull request
Sep 8, 2022
Improve alerts summary performance (#4376) * Reduced alerts summary bucket size * Added Alerts Summary table class * Added Alerts Summary table class * Added base configuration tables * feat: add structures for aggregation queries of summary tables of modules without selected agent * Split extended information and added agents tables * Code cleaning * Added optional chaining to conditionals * Added missing alerts summary definitions * Delete hidden vis and fix merge conflicts * Fix merge * Add changelog Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 395fb8a) Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
AlexRuiz7
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Reduced alerts summary bucket size * Added Alerts Summary table class * Added Alerts Summary table class * Added base configuration tables * feat: add structures for aggregation queries of summary tables of modules without selected agent * Split extended information and added agents tables * Code cleaning * Added optional chaining to conditionals * Added missing alerts summary definitions * Delete hidden vis and fix merge conflicts * Fix merge * Add changelog Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 395fb8a)
AlexRuiz7
added a commit
that referenced
this pull request
Sep 8, 2022
Improve alerts summary performance (#4376) * Reduced alerts summary bucket size * Added Alerts Summary table class * Added Alerts Summary table class * Added base configuration tables * feat: add structures for aggregation queries of summary tables of modules without selected agent * Split extended information and added agents tables * Code cleaning * Added optional chaining to conditionals * Added missing alerts summary definitions * Delete hidden vis and fix merge conflicts * Fix merge * Add changelog Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 395fb8a) Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way the Alerts Summary tables are created in PDF reports to improve the dashboards loading time. Now the tables configuration is the PDF report folder segregated by modules and the request to obtain the data is made by the backend of the app instead of the frontend.
This avoids unnecessary loading times when the user does not use the reporting feature.
Closes #3812
Comparative
Before
After