-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wazuh.yml link and in-file documentation #4378
Conversation
Remove unused settings. Centralize documentation. Add missing settings. Programatic file generation.
Also fixes some TS warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: the object that contains the default configuration could be muted, so changes in the configuration could do the plugin behaves as not expected ways.
The defaultConfig
variable should be a new object, so the changes in its properties doesn't affect to the object that contains the default configuration WAZUH_DEFATUL_APP_CONFIG
.
For this case, taking into account that the properties are in the first level, we could use the spread operator to "copy" the properties.
const defaultConfig = { ...WAZUH_DEFATUL_APP_CONFIG };
Solved in 4bb0519 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
Code review ✔️
Test ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅
Test ✅
* Review Wazuh.yml documentation Remove unused settings. Centralize documentation. Add missing settings. Programatic file generation. * Add Changelog * Fix indentation for hosts in the wazuh.yml Also fixes some TS warnings * Deep copy the WAZUH_DEFAULT_APP_CONFIG object (cherry picked from commit 1d44109)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4378-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1d441096398ed5e34e98048077520c78687788c0
# Push it to GitHub
git push --set-upstream origin backport-4378-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd Then, create a pull request where the |
Fix wazuh.yml link and in-file documentation (#4378) * Review Wazuh.yml documentation Remove unused settings. Centralize documentation. Add missing settings. Programatic file generation. * Add Changelog * Fix indentation for hosts in the wazuh.yml Also fixes some TS warnings * Deep copy the WAZUH_DEFAULT_APP_CONFIG object (cherry picked from commit 1d44109) Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
* Review Wazuh.yml documentation Remove unused settings. Centralize documentation. Add missing settings. Programatic file generation. * Add Changelog * Fix indentation for hosts in the wazuh.yml Also fixes some TS warnings * Deep copy the WAZUH_DEFAULT_APP_CONFIG object (cherry picked from commit 1d44109)
* Review Wazuh.yml documentation Remove unused settings. Centralize documentation. Add missing settings. Programatic file generation. * Add Changelog * Fix indentation for hosts in the wazuh.yml Also fixes some TS warnings * Deep copy the WAZUH_DEFAULT_APP_CONFIG object (cherry picked from commit 1d44109)
Summary
This PR solves the issue noted in the issue #4349 (comment).
Result
Test
wazuh.yml
file is created without errors.