Redesign the SCA table from agent's dashboard #4512

chantal-kelm · 2022-09-14T17:05:34Z

With the redesign of this section, the user accesses the information in a much more direct way.

This PR closes this issue.

For testing

Check the new SCA Lastest scans table in the Agent Dashboard

Select Agent and go to Agent Dashboard
Check table style in the SCA: Lastest scans card.
Click on the table row and check if redirect to the SCA > Inventory to the selected policy.

Check the SCA > Inventory behavior

Select Agent and go to Agent Dashboard
Click on the SCA title in the Header navigation ( SCA > Inventory)
Check the Policies table is rendered on the Inventory Tab.
Click in the Policy Table Row and check if is redirected to the Policy Checks view

asteriscos

There's a lot of commented code, please delete all unnecessary code. It would also be useful to improve the PR description to know exactly what to test.

public/components/agents/sca/inventory.tsx

Machi3mfl · 2022-10-17T19:15:23Z

Current behavior in this solution

The same SCA Policies table is used in two views: Agent Welcome and SCA Inventory. We need to modify this because if if change a layout for one it will modify for both views.

Next Steps

Create a new component to reuse in the sections mentioned above
Verify correct redirection when the row is clicked. From Agent Dashboard and SCA Inventory.
Fixes the Agent Welcome SCA style (Resolve the review comments)

Mayons95

TR: ✔️

Screencast.from.19-10-22.11.59.02.webm

asteriscos

CR: ✔️
Test: ❌
There's an error in the console when clicking a row.

AlexRuiz7

Changelog entry missing
Conflicts

asteriscos

When there are many rows in the table the cards grow too much. Maybe you could paginate the results to a max of 5 rows.

Machi3mfl · 2022-10-19T18:27:23Z

CR: heavy_check_mark Test: x There's an error in the console when clicking a row.

Solved ✔️

Machi3mfl · 2022-10-19T18:28:42Z

Changelog entry missing

Conflicts

Solved ✔️

Machi3mfl · 2022-10-19T18:29:09Z

When there are many rows in the table the cards grow too much. Maybe you could paginate the results to a max of 5 rows.

Solved ✔️

Solution details:

Used TableWzApi inside SCAPoliciesTable instead EuiBasicTable
Table in SCA Dashboard with PageSize 4 to prevent the scroll.
Added pagination.

Mayons95

LGTM

github-actions · 2022-10-21T12:11:38Z

Code coverage (Jest)	%	values
Statements	7.37%	( 2677 / 36320 )
Branches	3.19%	( 892 / 27998 )
Functions	5.13%	( 454 / 8856 )
Lines	7.46%	( 2593 / 34772 )

AlexRuiz7

Code review: ✔️
Test: ✔️

asteriscos

CR: ✔️
Test: ✔️

* SCA table: Latest scans * redirect and states * params url * the tables are working properly * styles * inventory test * styles euiFlexGroup * SCA test, back button and parameter renaming * load for tables * Added new policies table for reuse in agent welcome and sca * Fixed table redirection on row clicked * Solved review comments * Fixed policy row redirect, renaming and remove it unused code * Updated CHANGELOG * Added pagination * Updated snapshots to fix unit tests * Updated CHANGELOG * Fixed lastest scan navigation Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> (cherry picked from commit 138893d)

) Redesign the SCA table from agent's dashboard (#4512) * SCA table: Latest scans * redirect and states * params url * the tables are working properly * styles * inventory test * styles euiFlexGroup * SCA test, back button and parameter renaming * load for tables * Added new policies table for reuse in agent welcome and sca * Fixed table redirection on row clicked * Solved review comments * Fixed policy row redirect, renaming and remove it unused code * Updated CHANGELOG * Added pagination * Updated snapshots to fix unit tests * Updated CHANGELOG * Fixed lastest scan navigation Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> (cherry picked from commit 138893d) Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>

…4749) Redesign the SCA table from agent's dashboard (#4512) * SCA table: Latest scans * redirect and states * params url * the tables are working properly * styles * inventory test * styles euiFlexGroup * SCA test, back button and parameter renaming * load for tables * Added new policies table for reuse in agent welcome and sca * Fixed table redirection on row clicked * Solved review comments * Fixed policy row redirect, renaming and remove it unused code * Updated CHANGELOG * Added pagination * Updated snapshots to fix unit tests * Updated CHANGELOG * Fixed lastest scan navigation Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> (cherry picked from commit 138893d) Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>

SCA table: Latest scans

6d8e71c

chantal-kelm changed the title ~~SCA table: Latest scans~~ Redesign the agent's dashboard Sep 14, 2022

chantal-kelm added 4.4 labels Sep 14, 2022

chantal-kelm self-assigned this Sep 14, 2022

chantal-kelm linked an issue Sep 14, 2022 that may be closed by this pull request

Redesign the agent's dashboard #4238

Closed

chantal-kelm added 8 commits September 20, 2022 21:52

redirect and states

bf727a0

params url

7fba6a2

the tables are working properly

6bb26a4

styles

f9fa2fd

inventory test

6574890

styles euiFlexGroup

71f129d

SCA test, back button and parameter renaming

9e03a69

load for tables

ba53ea9

asteriscos requested changes Oct 13, 2022

View reviewed changes

public/components/agents/sca/inventory.tsx Outdated Show resolved Hide resolved

public/components/agents/sca/inventory.tsx Show resolved Hide resolved

public/components/agents/sca/inventory.tsx Outdated Show resolved Hide resolved

Added new policies table for reuse in agent welcome and sca

0089174

Machi3mfl added 2 commits October 18, 2022 12:03

Fixed table redirection on row clicked

e458ca6

Solved review comments

253912d

Machi3mfl marked this pull request as ready for review October 18, 2022 16:50

Machi3mfl requested a review from a team as a code owner October 18, 2022 16:50

Mayons95 previously approved these changes Oct 19, 2022

View reviewed changes

asteriscos approved these changes Oct 19, 2022

View reviewed changes

AlexRuiz7 suggested changes Oct 19, 2022

View reviewed changes

asteriscos requested changes Oct 19, 2022

View reviewed changes

Machi3mfl added 2 commits October 19, 2022 13:14

Merge branch '4.4-7.10' into 4238-Redesign-the-agents-dashboard

db0bdb0

Fixed policy row redirect, renaming and remove it unused code

65a3d96

Machi3mfl changed the title ~~Redesign the agent's dashboard~~ Added agent's dashboard redesign Oct 19, 2022

Updated CHANGELOG

d27f9f8

AlexRuiz7 changed the title ~~Added agent's dashboard redesign~~ Redesign the SCA table from agent's dashboard Oct 20, 2022

Machi3mfl added 5 commits October 20, 2022 10:54

Added pagination

8bd7d74

Merge branch '4.4-7.10' into 4238-Redesign-the-agents-dashboard

15e1e48

Updated snapshots to fix unit tests

59b6c63

Merge branch '4.4-7.10' into 4238-Redesign-the-agents-dashboard

f3b0873

Updated CHANGELOG

5b712e9

Machi3mfl dismissed Mayons95’s stale review via 5b712e9 October 20, 2022 14:49

Fixed lastest scan navigation

49f714f

Mayons95 self-requested a review October 20, 2022 15:12

Mayons95 approved these changes Oct 20, 2022

View reviewed changes

Machi3mfl added 2 commits October 20, 2022 13:15

Merge branch '4.4-7.10' into 4238-Redesign-the-agents-dashboard

3eb8834

Merge branch '4.4-7.10' into 4238-Redesign-the-agents-dashboard

4e4896c

AlexRuiz7 approved these changes Oct 21, 2022

View reviewed changes

asteriscos approved these changes Oct 21, 2022

View reviewed changes

AlexRuiz7 merged commit 138893d into 4.4-7.10 Oct 24, 2022

AlexRuiz7 deleted the 4238-Redesign-the-agents-dashboard branch October 24, 2022 07:59

github-actions bot mentioned this pull request Oct 24, 2022

[Backport 4.4-7.16] Redesign the SCA table from agent's dashboard #4748

Merged

github-actions bot mentioned this pull request Oct 24, 2022

[Backport 4.4-2.3-wzd] Redesign the SCA table from agent's dashboard #4749

Merged

Mayons95 mentioned this pull request Nov 22, 2022

Release 4.4.0 - Alpha 1 - Kibana UI regression testing #4895

Closed

7 tasks

Desvelao mentioned this pull request Dec 20, 2022

Fix vulnerabilities in dependencies #5014

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign the SCA table from agent's dashboard #4512

Redesign the SCA table from agent's dashboard #4512

chantal-kelm commented Sep 14, 2022 •

edited

Loading

asteriscos left a comment

Machi3mfl commented Oct 17, 2022 •

edited

Loading

Mayons95 left a comment

asteriscos left a comment •

edited

Loading

AlexRuiz7 left a comment •

edited

Loading

asteriscos left a comment •

edited

Loading

Machi3mfl commented Oct 19, 2022 •

edited

Loading

Machi3mfl commented Oct 19, 2022

Machi3mfl commented Oct 19, 2022 •

edited

Loading

Mayons95 left a comment

github-actions bot commented Oct 21, 2022

AlexRuiz7 left a comment

asteriscos left a comment

Redesign the SCA table from agent's dashboard #4512

Redesign the SCA table from agent's dashboard #4512

Conversation

chantal-kelm commented Sep 14, 2022 • edited Loading

For testing

Check the new SCA Lastest scans table in the Agent Dashboard

Check the SCA > Inventory behavior

asteriscos left a comment

Choose a reason for hiding this comment

Machi3mfl commented Oct 17, 2022 • edited Loading

Current behavior in this solution

Next Steps

Mayons95 left a comment

Choose a reason for hiding this comment

asteriscos left a comment • edited Loading

Choose a reason for hiding this comment

AlexRuiz7 left a comment • edited Loading

Choose a reason for hiding this comment

asteriscos left a comment • edited Loading

Choose a reason for hiding this comment

Machi3mfl commented Oct 19, 2022 • edited Loading

Machi3mfl commented Oct 19, 2022

Machi3mfl commented Oct 19, 2022 • edited Loading

Mayons95 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2022

AlexRuiz7 left a comment

Choose a reason for hiding this comment

asteriscos left a comment

Choose a reason for hiding this comment

chantal-kelm commented Sep 14, 2022 •

edited

Loading

Machi3mfl commented Oct 17, 2022 •

edited

Loading

asteriscos left a comment •

edited

Loading

AlexRuiz7 left a comment •

edited

Loading

asteriscos left a comment •

edited

Loading

Machi3mfl commented Oct 19, 2022 •

edited

Loading

Machi3mfl commented Oct 19, 2022 •

edited

Loading